Smarter helper rules #682
Draft
Smarter helper rules #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihozhang
commented
Nov 23, 2024
| :ruleset type-helpers) | ||
|
|
||
| (function TypeList-length (TypeList) i64 :unextractable) | ||
| (function TypeList-ith (TypeList i64) BaseType :unextractable) | ||
| (function TypeList-suffix (TypeList i64) TypeList :unextractable) |
There was a problem hiding this comment.
The old TypeList-suffix based implementation is quadratic in the size of the list (which easily goes to 20+)
yihozhang
commented
Nov 30, 2024
| (rule ((Get expr i)) | ||
| ((union (Single (Get expr i)) | ||
| (SubTuple expr i 1))) | ||
| ; ;; This rule makes sure every tuple can be |
There was a problem hiding this comment.
this is actually unnecessary because we are already generating gets for every "important" tuple. Removed in my new PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eggcc has been constantly blowing up with the giant analyses our helpers generate. But do our helpers really need to generate that many facts? We explore the question in this PR.
GetandTypeList-ithare quadratic